Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on standard go-car release #670

Closed
BigLep opened this issue Jul 22, 2022 · 1 comment · Fixed by #906
Closed

Depend on standard go-car release #670

BigLep opened this issue Jul 22, 2022 · 1 comment · Fixed by #906

Comments

@BigLep
Copy link
Member

BigLep commented Jul 22, 2022 •
edited

Currently Boost is dependenging on a custom branch of go-car:

https://github.com/filecoin-project/boost/blob/main/go.mod#L65

github.com/ipld/go-car v0.4.1-0.20220707083113-89de8134e58e
github.com/ipld/go-car/v2 v2.4.2-0.20220707083113-89de8134e58e

I believe this is for the extra functionality in ipld/go-car#290.

I'd like to get this resolved given the complications it caused when resolving GHSA-9x4h-8wgm-8xfg. The reason to prioritize this is so we maintain good operational posture for a future go-car event by reducing moving pieces.
@jacobheun jacobheun added this to the v1.3.0 milestone Jul 25, 2022
@jacobheun
Copy link
Contributor

Looking at resolving this by landing ipld/go-car#291.

@jacobheun jacobheun modified the milestones: v1.3.0, v1.4.0 Aug 10, 2022
@jacobheun jacobheun removed this from the v1.4.0 milestone Oct 14, 2022
rvagg added a commit that referenced this issue Oct 19, 2022
@rvagg
fix: use tagged go-car release instead of custom branch
497e768 
Closes: #670

Because CarOffsetWriter got copied into boost, it doesn't need to use the
custom branch.
@rvagg rvagg mentioned this issue Oct 19, 2022
Merged
dirkmc pushed a commit that referenced this issue Oct 20, 2022
@rvagg
fix: use tagged go-car release instead of custom branch (#906)
2b3394e 
Closes: #670

Because CarOffsetWriter got copied into boost, it doesn't need to use the
custom branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Boost
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use tagged go-car release instead of custom branch filecoin-project/boost
2 participants
@BigLep @jacobheun