Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity centres and masters: remove trailing and leading whitespace from search values in autocompleters #2192

Open
01es opened this issue Feb 22, 2024 · 0 comments · May be fixed by #2200
Open

Comments

@01es
Copy link
Member

01es commented Feb 22, 2024

Description

Leading and trailing whitespace is not permitted for key values. However, it is possible to enter such whitespace, usually unintentionally, when typing search strings into selection criteria or editors for entity-typed properties. The whitespace is then used as part of the search string, returning no results. And so, users need to realise that they have typed a space before or after a search string, which is far from obvious.

To improve usability, it is proposed to automatically remove leading and trailing spaces from search strings used in entity-typed selection criteria and entity property editors when preparing a query.

Expected outcome

Improved usability.

@01es 01es added this to the v1.4.6 M2 milestone Feb 22, 2024
@01es 01es changed the title Entity centre: remove trailing and leading whitespace from entity-typed selection criteria Entity centres and masters: remove trailing and leading whitespace from search values in autocompleters Feb 26, 2024
@oleh-maikovych oleh-maikovych self-assigned this Feb 26, 2024
oleh-maikovych added a commit that referenced this issue Feb 26, 2024
… problem when someone unintentionally enters trailing whitespaces
oleh-maikovych added a commit that referenced this issue Feb 27, 2024
…are utility method to control triming of input string.
oleh-maikovych added a commit that referenced this issue Feb 28, 2024
… to trim just search from entity editors. Also adjusted for preparing serach criterias to separate entity editors search criteira from string search criterias.
01es added a commit that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment