Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPad detection #1374

Open
oleh-maikovych opened this issue Jul 15, 2019 · 1 comment · May be fixed by #1407
Open

iPad detection #1374

oleh-maikovych opened this issue Jul 15, 2019 · 1 comment · May be fixed by #1407
Assignees
@oleh-maikovych
Labels
On hold UI / UX

Comments

@oleh-maikovych
Copy link
Contributor

Description

Currently client's code detects the device type in order to provide appropriate menu configuration and other device related features. But, as it was reported by @01es, client's code identifies iPad as a mobile device which is incorrect.

Expected outcome

The iPad should loads the desktop menu configuration

Actual outcome

The iPad loads the mobile menu configuration
@oleh-maikovych oleh-maikovych added this to the v1.4 M37 milestone Jul 15, 2019
@oleh-maikovych oleh-maikovych self-assigned this Jul 15, 2019
@oleh-maikovych oleh-maikovych added this to To Do in Migrating to Polymer 3.x and beyond via automation Jul 15, 2019
oleh-maikovych added a commit that referenced this issue Jul 15, 2019
@oleh-maikovych
#1374 Updated device determination logic using ua-parser TODO: should…
57682ff 
… also test it on iPhone and iPad
@oleh-maikovych oleh-maikovych mentioned this issue Jul 16, 2019
Closed
@01es 01es added On hold and removed In progress labels Jul 17, 2019
@01es
Copy link
Member

01es commented Jul 17, 2019

This issue has been tested and works well. However, it should not be merged until other iPad related issues are resolved.

@01es 01es removed this from the v1.4 M37 milestone Jul 17, 2019
01es added a commit that referenced this issue Aug 21, 2019
@01es
Merge branch 'develop' into Issue-#1374
a91e8b3
@01es 01es linked a pull request Aug 21, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleh-maikovych oleh-maikovych

Labels
On hold UI / UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1374 - iPad detection fieldenms/tg
2 participants
@01es @oleh-maikovych