Update README.md #423
Merged
Update README.md #423
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `require` with ESM import
jeromewu
requested changes
Sep 23, 2022
| @@ -69,8 +69,7 @@ Or, using a script tag in the browser (only works in some browsers, see list bel | |||
| ffmpeg.wasm provides simple to use APIs, to transcode a video you only need few lines of code: | |||
|
|
|||
| ```javascript | |||
| const fs = require('fs'); | |||
| const { createFFmpeg, fetchFile } = require('@ffmpeg/ffmpeg'); | |||
| import { createFFmpeg, fetchFile } from '@ffmpeg/ffmpeg'; | |||
There was a problem hiding this comment.
I think we still need to import fs here
There was a problem hiding this comment.
Good catch - hopefully the named import I've added works for you
|
Thanks for the PR! Just one minor part to improve, thanks! |
Import writeFile
|
Done! I've added |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
requirewith ESM import