Add ruby source files to the java gem #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to ffi#747 . JRuby-9.3 is expected to be fully compatible to this gem's Ruby code. This allows to ship the Ruby library code per platform java gem and add it as a default gem to JRuby.
larskanis
commented
Mar 30, 2020
headius
added a commit
to headius/ffi
that referenced
this pull request
Sep 22, 2020
When running with --disable-gems, JRuby still needs to be able to load FFI from stdlib. Accessing the Gem namespace here requires that gems not be disabled. This patch uses a simple split and integer comparison to compare the first two digits of the JRuby version with 9.3. See ffi#763 for the original code.
headius
added a commit
to headius/ffi
that referenced
this pull request
Sep 22, 2020
When running with --disable-gems, we still need to be able to load FFI from stdlib. Accessing the Gem namespace here requires that gems not be disabled. This patch splits and compares the integer elements of version directly rather than using Gem::Version to do that comparison. See ffi#763 for the original code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #747 .
JRuby-9.3 is expected to be fully compatible to this gem's Ruby code. This allows to ship the Ruby library code per platform java gem and add it as a default gem to JRuby.