Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi 1.11 fails to build on ruby 1.9.3 #699

Closed
aflat opened this issue May 17, 2019 · 2 comments
Closed

ffi 1.11 fails to build on ruby 1.9.3 #699

aflat opened this issue May 17, 2019 · 2 comments

Comments

@aflat
Copy link

aflat commented May 17, 2019 •
edited

I can't build fpm on centos6 because it requires me to build ruby 1.9.3. I can compile ruby 1.9.3, then I try to gem install fpm, which depends on ffi. When it tries to compile ffi 1.11 it fails

make[3]: Leaving directory `/usr/local/lib/ruby/gems/1.9.1/gems/ffi-1.11.0/ext/ffi_c/libffi-x86_64-linux'
make[2]: Leaving directory `/usr/local/lib/ruby/gems/1.9.1/gems/ffi-1.11.0/ext/ffi_c/libffi-
make[1]: Leaving directory `/usr/local/lib/ruby/gems/1.9.1/gems/ffi-1.11.0/ext/ffi_c/libffi-x86_64-linux'
compiling Pointer.c
compiling Platform.c
compiling StructLayout.c
compiling Buffer.c
compiling MethodHandle.c
compiling LongDouble.c
compiling Type.c
compiling StructByValue.c
compiling Call.c
Call.c:46:25: error: ruby/thread.h: No such file or directory

using ffi 1.10 works fine.
larskanis added a commit that referenced this issue May 18, 2019
@larskanis
Raise ruby version requirement to >=2.0
08b9b78 
Related to #699
@larskanis
Copy link
Member

ffi-1.11.0 will no longer work on Ruby-1.9. We removed the old compatibility code in #683 . I just forgot to raise the ruby version requirement in the gemspec. You'll have to stay at ffi-1.10.0 or update ruby.

benoittgt added a commit to rspec/rspec-support that referenced this issue May 18, 2019
@benoittgt
Deal with new ffi Ruby version requirement
8b3fda4 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
@benoittgt benoittgt mentioned this issue May 18, 2019
Merged
benoittgt added a commit to rspec/rspec-expectations that referenced this issue May 18, 2019
@benoittgt
CI was failing for 1.9.2 and 1.9.3. This is due to
35cdf7b 
ffi/ffi#683

Related:
- ffi/ffi#699
@benoittgt benoittgt mentioned this issue May 18, 2019
Merged
benoittgt added a commit to rspec/rspec-collection_matchers that referenced this issue May 18, 2019
@benoittgt
CI was failing for 1.9.2 and 1.9.3. This is due to
2402537 
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-collection_matchers that referenced this issue May 18, 2019
@benoittgt
Deal with new ffi Ruby version requirement
80bcda6 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
@benoittgt benoittgt mentioned this issue May 18, 2019
Closed
benoittgt added a commit to rspec/rspec-collection_matchers that referenced this issue May 18, 2019
@benoittgt
Deal with new ffi Ruby version requirement
2460a77 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-support that referenced this issue May 18, 2019
@benoittgt
Deal with new ffi Ruby version requirement
27af781 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-expectations that referenced this issue May 18, 2019
@benoittgt
Deal with new ffi Ruby version requirement
829551e 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to benoittgt/rspec-mocks that referenced this issue May 18, 2019
@benoittgt
Deal with new ffi Ruby version requirement
458fbbf 
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-mocks that referenced this issue May 18, 2019
@benoittgt
Deal with new ffi Ruby version requirement
3678e8b 
ffi/ffi#683

Related:
- ffi/ffi#699
@benoittgt benoittgt mentioned this issue May 18, 2019
Merged
@mvz
Copy link
Contributor

mvz commented May 19, 2019

How about testing down to version 2.0 on Travis to avoid this happening in the future?

This was referenced May 19, 2019
Merged
Merged
JonRowe pushed a commit to rspec/rspec-mocks that referenced this issue May 19, 2019
@benoittgt @JonRowe
Deal with new ffi Ruby version requirement (#1276)
5f3f68f 
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-collection_matchers that referenced this issue May 19, 2019
@benoittgt
Deal with new ffi Ruby version requirement
d89dede 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-expectations that referenced this issue May 19, 2019
@benoittgt
Deal with new ffi Ruby version requirement
7ce0882 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-support that referenced this issue May 19, 2019
@benoittgt
Deal with new ffi Ruby version requirement
cbd22df 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-collection_matchers that referenced this issue May 19, 2019
@benoittgt
Deal with new ffi Ruby version requirement
9c0bdf6 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
benoittgt added a commit to rspec/rspec-expectations that referenced this issue May 19, 2019
@benoittgt
Deal with new ffi Ruby version requirement
9689e89 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
JonRowe pushed a commit to rspec/rspec-expectations that referenced this issue May 20, 2019
@benoittgt @JonRowe
Deal with new ffi Ruby version requirement (#1115)
1044d4e 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
@larskanis larskanis mentioned this issue May 20, 2019
Closed
JonRowe pushed a commit to rspec/rspec-mocks that referenced this issue Jun 13, 2019
@benoittgt @JonRowe
Deal with new ffi Ruby version requirement (#1276)
6181de2 
ffi/ffi#683

Related:
- ffi/ffi#699
JonRowe pushed a commit to rspec/rspec-mocks that referenced this issue Jun 13, 2019
@benoittgt @JonRowe
Deal with new ffi Ruby version requirement (#1276)
2182ced 
ffi/ffi#683

Related:
- ffi/ffi#699
JonRowe pushed a commit to rspec/rspec-expectations that referenced this issue Oct 7, 2019
@benoittgt @JonRowe
Deal with new ffi Ruby version requirement (#1115)
dbf72e5 
CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this issue Oct 6, 2021
@benoittgt @JonRowe
[mocks] Deal with new ffi Ruby version requirement (rspec/rspec-mocks…
1cec7e6 
…#1276)

ffi/ffi#683

Related:
- ffi/ffi#699

---
This commit was imported from rspec/rspec-mocks@2182ced.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this issue Oct 6, 2021
@benoittgt @JonRowe
[expectations] Deal with new ffi Ruby version requirement (rspec/rspe…
0504c43 
…c-expectations#1115)

CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699

---
This commit was imported from rspec/rspec-expectations@dbf72e5.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this issue Oct 6, 2021
@benoittgt @JonRowe
[mocks] Deal with new ffi Ruby version requirement (rspec/rspec-mocks…
ce11006 
…#1276)

ffi/ffi#683

Related:
- ffi/ffi#699

---
This commit was imported from rspec/rspec-mocks@5f3f68f.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this issue Oct 6, 2021
@benoittgt @JonRowe
[expectations] Deal with new ffi Ruby version requirement (rspec/rspe…
00101c8 
…c-expectations#1115)

CI was failing for 1.9.2 and 1.9.3. This is due to
ffi/ffi#683

Related:
- ffi/ffi#699

---
This commit was imported from rspec/rspec-expectations@1044d4e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mvz @larskanis @aflat