Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FFI::Pointer#read_string(0) to return a binary String #692

Merged
merged 1 commit into from Apr 12, 2019
Merged

Fix FFI::Pointer#read_string(0) to return a binary String #692

merged 1 commit into from Apr 12, 2019

Conversation

eregon
Copy link
Collaborator

@eregon eregon commented Apr 11, 2019

@eregon
Fix FFI::Pointer#read_string(0) to return a binary String
4c92387 
* Like other pointer string methods and usages.
* Fixes ffi#691.
* String#b is available since Ruby 2.0.
@eregon
Copy link
Collaborator Author

eregon commented Apr 11, 2019

cc @larskanis

@larskanis larskanis merged commit 59934bb into ffi:master Apr 12, 2019
@larskanis
Copy link
Member

Good catch, makes sense!

@eregon
Copy link
Collaborator Author

eregon commented Apr 12, 2019

@larskanis Thanks for merging :)

@eregon eregon mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FFI::Pointer#read_string(0) returns a UTF-8 and not a binary String
2 participants
@eregon @larskanis