Move FFI::Platform::CPU from C to Ruby and remove duplicated libtest #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CPU detection was moved to C 10 years ago as a workaround to an incorrect RbConfig::CONFIG['host_cpu'] value on MacOS. This was in commit c53282a . Although I can't reproduce the original environment, I guess that this issue has been fixed years ago, so that the workaround isn't necessary anymore. Moving CPU detection to Ruby allows to use lib/ffi/platform.rb in Rakefile before the C ext is built.
The test library has been moved to spec/ffi/fixtures and it's built by the spec helper. This was in commit c79e9f5 . Since that time we managed two copies of these tests, but only the one in spec/ffi/fixtures is actually used.
|
Looks great to me. |
|
Let's merge this :) Anything we need to wait for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for more details.