Switch time_t and suseconds_t types to long on FreeBSD #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Come on folks, this is embarrassing this issue has been open for almost 2 years now (#544) it's a 6 line fix, which I provided in the description exactly what needed to be done. You now HAVE the pull request (for a trivial 6 line fix)... that itself has been open for 6 months. In the 2 years since this trivial bug report was opened you have done 9 releases. Thankfully you haven't done any in the 6 months since you have had the pull request; not that I'd put it past you at this point (no, this isn't a challenge) |
|
Thank you, merged! |
This was referenced Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently time_t and suseconds_t are ints, which should be longs. This causes problems with various libraries, but especially anything that uses select()
See here: freebsd/freebsd-ports@ed7f235
And: typhoeus/ethon#98