Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove plugin installation confirmation stutter #2292

Closed
michelleN opened this issue Feb 23, 2024 · 2 comments · Fixed by #2295
Closed

remove plugin installation confirmation stutter #2292

michelleN opened this issue Feb 23, 2024 · 2 comments · Fixed by #2295

Comments

@michelleN
Copy link
Member

Every time I install a plugin, I get an installation confirmation prompt. When I select yes, the prompt is displayed again with the final confirmation. This happens when the prompt is very long. If I remove the url from the prompt string, I don't get the stutter or second prompt with confirmation. This also doesn't happen if I use a different crate for displaying the confirmation dialogue like promptly.

Screenshot 2024-02-23 at 11 47 24 AM
  • Spin version (spin --version)
    spin 2.3.0-pre0 (78f84e7 2024-02-21)

Would love for us to figure out a way to remove the stutter.

@karthik2804
Copy link
Contributor

Related open issue in the dialouger crate for this. We could split up the metadata and a smaller yes or no line? Something along the lines of

You are trying to install plugin `trigger-cron` with license Apache-2.0 from https://github.com/fermyon/spin-trigger-cron/releases/download/canary/trigger-cron-0.1-macos-aarch64.tar.gz

Are you sure you want to continue? (y/n)

@michelleN
Copy link
Member Author

yea that sounds good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants