New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"No source information" in pprof format #21
Comments
Hey, sorry for the very late reply! I just took a look, and this is currently broken because I initially was just targeting brendan gregg's folded text format (which doesn't contain file/line info) and then didn't rework the code to propagate this information when I added pprof support. So in theory it should be a relatively easy fix! I don't know if I'll get a around to it soon, but I'd be happy to merge a patch for this quickly! |
I don't know whether I'll get around to it either, but could you suggest a file or function which is a good place to start looking how to add it? |
Let's perhaps change the title of this issue to |
I needed this to work so I hacked it in the simplest way. It works but it is inefficient and ugly, as Felix mentions in a TODO comment the interface between the functions need to be improved. I didn't bother to make a PR as it is clearly not the right way of solving this, but it does work (at least for my use case, have not tried this extensively). |
Tried out the new version and the file and line number info seems to be working as it should for my use case. Thanks! |
I added
github.com/felixge/fgprof
to one of the Prometheus unit tests, which gives me good charts but no source line info:I can work on a repro if it's interesting; didn't know whether I should expect it to work.
I'm running
go version go1.17.8 linux/amd64
.The text was updated successfully, but these errors were encountered: