Populate PeriodType appropriately #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
force-pushed
the
periodtype
branch
2 times, most recently
from
fc37cc3
to
0b9f4c4
Compare
kakkoyun
approved these changes
Apr 28, 2022
felixge
requested changes
May 8, 2022
format.go
Outdated
| @@ -60,6 +60,10 @@ func toPprof(s map[string]int, hz int) *profile.Profile { | |||
| Unit: "nanoseconds", | |||
| }, | |||
| } | |||
| p.PeriodType = &profile.ValueType{ | |||
| Type: "cpu", | |||
There was a problem hiding this comment.
I think this is misleading. fgprof does not produce CPU profiles. It produces "wallclock" profiles.
So maybe this?
Suggested change
| Type: "cpu", | |
| Type: "wallclock", |
PeriodType is intended to explain the kind of events between sampled occurrences. While not strictly required to be set, all the Go stdlib profilers populate it, and this patch sets it equivalent to the standard CPU profiles.
Having both toPprof and toProfile was an accident and the latter was dead code.
|
Thanks for the patch. Sorry for the slow response. Noticed some accidental code duplication while reviewing this, so pushed a small fix for that before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeriodType is intended to explain the kind of events between sampled
occurrences. While not strictly required to be set, all the Go stdlib
profilers populate it, and this patch sets it equivalent to the standard
CPU profiles.
Resolves part of #16