Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't support profile labels? #14

Open
helios741 opened this issue Nov 16, 2021 · 1 comment
Open

Don't support profile labels? #14

helios741 opened this issue Nov 16, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@helios741
Copy link

Thanks for providing such a great tool. It would be helpful if profile labels were supported to troubleshoot io problems.

@felixge felixge added the help wanted Extra attention is needed label Dec 19, 2021
@felixge
Copy link
Owner

felixge commented Dec 19, 2021

Sorry for the late reply. Yeah, this sounds like a nice idea. The problem is that the API I'm currently using doesn't expose labels and the other APIs may have more overhead, see https://github.com/DataDog/go-profiler-notes/blob/main/goroutine.md#feature-matrix

That being said, if somebody wants to make a patch to optionally use a different API, I'd be happy to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants