Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container Patch Scripts for Prebuilt Images #220

Open
OrangeDrangon opened this issue Jun 22, 2021 · 1 comment
Open

Container Patch Scripts for Prebuilt Images #220

OrangeDrangon opened this issue Jun 22, 2021 · 1 comment

Comments

@OrangeDrangon
Copy link

🚀 Feature Proposal

Enable some method of running container patch scripts for containers built with credentials.

Motivation

I prefer to build the containers with foundry installed using my credentials but also enjoy the convenience of the patch scripts. I personally patched entrypoint.sh to run the patch scripts every launch not just when foundry is being installed but figured there might be a better mechanism for this. Potentially running them during container build. Figured I would propose the option.

Example

The best implementation of this I see is adding patch scripts as a build ARG just like the credentials are. This would enable the scripts to be run just once while also providing nearly the same experience as passing the urls as environment variables.

Pitch

It is a simple extension of a preexisting feature. Should add little to no maintenance cost on the project. I would be willing to give it a go for my own personal usage if anyone is interested here.

@OrangeDrangon
Copy link
Author

Opened a pull request draft that begins to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants