Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow starting of container if foundryvtt.com is down, and release zip has already been downloaded #212

Open
cs96and opened this issue Jun 2, 2021 · 1 comment

Comments

@cs96and
Copy link

cs96and commented Jun 2, 2021

🚀 Feature Proposal

foundryvtt.com went down for a few minutes earlier today, at the same time that I was trying to bring my container up. The container failed to authenticate and gave up.

The release zip had already been downloaded from a previous run, and was in the cache, so it could have just carried on with the cached one.

@felddy felddy self-assigned this Jun 3, 2021
@felddy
Copy link
Owner

felddy commented Jun 3, 2021

This makes sense.

I think the behavior you are looking for is the same as if FOUNDRY_USERNAME and/or FOUNDRY_PASSWORD are not specified. As documented here: https://github.com/felddy/foundryvtt-docker#required-combinations

So if authentication fails all is not lost. We can still fail forward to the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants