feat!: support type args #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for taking the time to open a PR! I'll review as soon as I can. 🙏 |
felangel
reviewed
Aug 18, 2021
|
Updated formatting but it looks like tests are failing now. I'll try to take a look tomorrow. |
That was a weird break, something related to the local package dir. Maybe a re-run? |
|
@renancaraujo tests are failing with the current implementation. You can run them locally for more information. I'll try to take a closer look soon but haven't had time recently. |
felangel
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
Possible tests that were positive before can be flagged as negative now.
Description
Add support for type args. More on this: #66
Type of Change