Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mason_logger): Windows terminals not showing animation progress #619

Closed
LukeMoody01 opened this issue Nov 13, 2022 · 2 comments · Fixed by #620
Closed

fix(mason_logger): Windows terminals not showing animation progress #619

LukeMoody01 opened this issue Nov 13, 2022 · 2 comments · Fixed by #620
Assignees
Labels
bug Something isn't working

Comments

@LukeMoody01
Copy link
Contributor

Description

When running the creation of bricks that use the Logger.progress method, the animation is not shown on windows terminals.

I did some testing and this is caused by the stdioType check, in PR #582
It seems the stdioType for windows is 'static'(See below screenshot). Not too sure how this will pan out in checking for this?

Steps To Reproduce

Windows Device:

  1. Open a cmd/powershell/vscode terminal
  2. Run a brick with an animation (A simple demo animation pre-hook will do)
  3. Verify result (Animation only shows first frame)

Expected Behavior

When on windows, the user should be able to see the animation in powershell/cmd/vscode terminal

Screenshots

image

Additional Context

N/A

@LukeMoody01 LukeMoody01 added the bug Something isn't working label Nov 13, 2022
@LukeMoody01 LukeMoody01 changed the title fix: Windows terminals not showing animation progress fix(mason_logger): Windows terminals not showing animation progress Nov 13, 2022
@felangel felangel self-assigned this Nov 13, 2022
@felangel
Copy link
Owner

Hey @LukeMoody01 👋
Thanks for catching this! It should be resolved in mason_logger v0.2.3 and you should be able to re-activate mason_cli to upgrade your logger version:

dart pub global activate mason_cli

@LukeMoody01
Copy link
Contributor Author

Legend! Thanks, @felangel! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants