Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(mason): compile hooks #613

Merged
merged 24 commits into from Nov 12, 2022
Merged

perf(mason): compile hooks #613

merged 24 commits into from Nov 12, 2022

Conversation

felangel
Copy link
Owner

@felangel felangel commented Nov 9, 2022

Status

READY

Description

  • perf(mason): compile hooks

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 💨 Performance

@felangel felangel self-assigned this Nov 9, 2022
@felangel felangel added the performance Performance improvement label Nov 11, 2022
@felangel felangel marked this pull request as ready for review November 11, 2022 05:51
wolfenrain
wolfenrain previously approved these changes Nov 11, 2022
@@ -93,4 +93,4 @@ jobs:
dart pub global activate pana

- name: Verify Pub Score
run: ../../tool/verify_pub_score.sh
run: ../../tool/verify_pub_score.sh 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 on purpose?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah until mason is published because pana doesn’t take into account dependency overrides

@felangel felangel merged commit 25336ae into master Nov 12, 2022
@felangel felangel deleted the perf/compile-hooks branch November 12, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants