Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mason_logger): only animate progress on terminals #582

Merged
merged 5 commits into from Nov 1, 2022

Conversation

felangel
Copy link
Owner

@felangel felangel commented Oct 28, 2022

Status

READY

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Oct 28, 2022
@felangel felangel force-pushed the fix/logger-progress-avoid-animating-progress branch 2 times, most recently from 4f7cf73 to 10d5b2c Compare October 28, 2022 04:11
@felangel felangel force-pushed the fix/logger-progress-avoid-animating-progress branch from 10d5b2c to 080ea86 Compare October 28, 2022 04:15
@felangel felangel force-pushed the fix/logger-progress-avoid-animating-progress branch 3 times, most recently from 4c3fb68 to c05781e Compare October 30, 2022 22:04
@felangel felangel force-pushed the fix/logger-progress-avoid-animating-progress branch from c05781e to d125390 Compare October 30, 2022 22:05
@felangel felangel marked this pull request as ready for review October 30, 2022 22:07
@felangel felangel added the bug Something isn't working label Oct 30, 2022
@felangel felangel merged commit 1797631 into master Nov 1, 2022
@felangel felangel deleted the fix/logger-progress-avoid-animating-progress branch November 1, 2022 04:05
@felangel
Copy link
Owner Author

felangel commented Nov 1, 2022

@wolfenrain thanks for the review!

alestiago pushed a commit to alestiago/mason that referenced this pull request Jun 9, 2023
…docs (felangel#582)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(mason_logger): Don't print the spinner when output is not a tty
2 participants