Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mason_logger): progress on android studio terminal #549

Merged
merged 3 commits into from Oct 19, 2022

Conversation

renancaraujo
Copy link
Collaborator

Status

READY

Description

fix: VeryGoodOpenSource/very_good_cli#499

Most terminals don't consider ANSI sequences as characters to be rem loved from the terminal. And we relied on inserted string lengths that included ANSI sequence characters in its length, causing an excess of backspaces applied on a "clear line" string.

The problem is that IntelliJ IDE's terminals don't block excess backspaces allowing deleting upper lines.

This PR changes the way we clear lines on mason logger's progress in a way we won't rely on string lengths and sequential backspaces.

Instead, we clear lines and then apply \r (carriage return) to make the cursor go to the beginning of the line.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel changed the title fix: progress on android studio terminal fix(mason_logger): progress on android studio terminal Oct 18, 2022
@felangel felangel added the bug Something isn't working label Oct 18, 2022
Copy link
Collaborator

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't been able to reproduce the issues I saw on vscode

Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the awesome contribution! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: animation in intellij idea (android studio) IDE
3 participants