fix(mason_logger): progress on android studio terminal #549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
fix: VeryGoodOpenSource/very_good_cli#499
Most terminals don't consider ANSI sequences as characters to be rem loved from the terminal. And we relied on inserted string lengths that included ANSI sequence characters in its length, causing an excess of backspaces applied on a "clear line" string.
The problem is that IntelliJ IDE's terminals don't block excess backspaces allowing deleting upper lines.
This PR changes the way we clear lines on mason logger's progress in a way we won't rely on string lengths and sequential backspaces.
Instead, we clear lines and then apply
\r
(carriage return) to make the cursor go to the beginning of the line.Type of Change