Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mason_logger): generic support for chooseOne and chooseAny #539

Merged
merged 11 commits into from Oct 13, 2022
Merged

feat(mason_logger): generic support for chooseOne and chooseAny #539

merged 11 commits into from Oct 13, 2022

Conversation

wolfenrain
Copy link
Collaborator

Status

READY

Description

Allows for chooseAny and chooseOne to receive a generic value and map it to string to display.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the enhancement New feature or request label Oct 12, 2022
wolfenrain and others added 5 commits October 13, 2022 16:40
@wolfenrain @felangel
Update packages/mason_logger/example/main.dart
2f98b7e 
Co-authored-by: Felix Angelov <felangelov@gmail.com>
@wolfenrain @felangel
Update packages/mason_logger/example/main.dart
eb9516d 
Co-authored-by: Felix Angelov <felangelov@gmail.com>
@felangel
minor tweaks
b4284db
@felangel
generic tweaks
13e9b0e
@felangel
simplify test
833c287
@felangel felangel changed the title feat(mason_logger): make chooseOne and chooseAny feat(mason_logger): generic support for chooseOne and chooseAny Oct 13, 2022
felangel
felangel approved these changes Oct 13, 2022
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@felangel felangel merged commit 8adaa25 into master Oct 13, 2022
@felangel felangel deleted the feat/make-choose-one-and-choose-any-mappable branch October 13, 2022 15:23
alestiago pushed a commit to alestiago/mason that referenced this pull request Jun 9, 2023
@felangel
chore(dart_frog): v0.3.3 (felangel#539)
2229b4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@wolfenrain wolfenrain

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wolfenrain @felangel