Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger): add link #517

Merged
merged 8 commits into from Sep 16, 2022
Merged

feat(logger): add link #517

merged 8 commits into from Sep 16, 2022

Conversation

Luckey-Elijah
Copy link
Contributor

@Luckey-Elijah Luckey-Elijah commented Sep 15, 2022

Status

READY

Description

Resolves #462

  • Adds the link function for utility.
  • Adds the Logger.linkmethod to write links to stdout (or with option "writer")

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@Luckey-Elijah
Copy link
Contributor Author

@felangel ready for review πŸ™‚

@Luckey-Elijah Luckey-Elijah changed the title feat(mason_logger): adds linkWrap util and Logger.link method feat(logger): adds linkWrap util and Logger.link method Sep 15, 2022
@felangel felangel added the enhancement New feature or request label Sep 15, 2022
@Luckey-Elijah Luckey-Elijah changed the title feat(logger): adds linkWrap util and Logger.link method feat(logger): adds linkWrap util Sep 15, 2022
@Luckey-Elijah Luckey-Elijah changed the title feat(logger): adds linkWrap util feat(logger): adds link util Sep 16, 2022
@Luckey-Elijah
Copy link
Contributor Author

Ready for a second another look. just have the single link function for wrapping messages

@felangel
Copy link
Owner

Ready for a second another look. just have the single link function for wrapping messages

Sweet, thanks! Will review/merge shortly πŸŽ‰

@felangel felangel changed the title feat(logger): adds link util feat(logger): add link Sep 16, 2022
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the contribution! πŸ’―

@felangel felangel merged commit 38a525b into felangel:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add link ansi wrapper
2 participants