feat(mason_logger): add ProgressOptions API #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
felangel
reviewed
Aug 1, 2022
felangel
changed the title
felangel
approved these changes
Oct 13, 2022
alestiago
pushed a commit
to alestiago/mason
that referenced
this pull request
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This PR addresses the open issue #451
I have given the .progress API an optional value where developers can pass through their own array of strings they want to animate through.
If nothing is given, we will fall back to the original progressAnimation.
Note: If the developer passes an empty array, this will break the logger (IntegerDivisionByZeroException). Do we want to check for this? Or should the developer just not pass through an empty array?
Let me know if there's anything that needs changing!
Type of Change