Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make variables without a default value mandatory #1108

Open
1 task
feinstein opened this issue Oct 10, 2023 · 2 comments
Open
1 task

feat: Make variables without a default value mandatory #1108

feinstein opened this issue Oct 10, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@feinstein
Copy link

Description

I want to force my users to provide some values, so empty strings are not acceptable, but currently, if I remove the default field, I am still able to provide empty values.

IMO if someone wants a value that can be empty, then they should provide it as default: "" or default:. If no default was provided, then the tool should enforce that users give it a value.

Requirements

  • Mandatory variables.
@felangel felangel self-assigned this Oct 10, 2023
@felangel felangel added the enhancement New feature or request label Oct 10, 2023
@feinstein
Copy link
Author

@felangel one more example on how this could be useful. I wanted to use this template:

defaults.project={{#sentryProjectName}}{{sentryProjectName}}{{/sentryProjectName}}{{^sentryProjectName}}{{packageName}}{{/sentryProjectName}}

But it doesn't work because sentryProjectName is always a string, so the string will always be defined and the {{^sentryProjectName}} option will never be triggered.

@utpal-barman
Copy link

Yes, this will be super useful if we can include required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants