Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tox requires and minversion somehow #39

Closed
hroncok opened this issue Feb 2, 2021 · 3 comments · Fixed by #40
Closed

Expose tox requires and minversion somehow #39

hroncok opened this issue Feb 2, 2021 · 3 comments · Fixed by #40
Assignees
Labels
enhancement New feature or request

Comments

@hroncok
Copy link
Member

hroncok commented Feb 2, 2021

See https://tox.readthedocs.io/en/latest/config.html#conf-requires

Specify python packages that need to exist alongside the tox installation for the tox build to be able to start (must be PEP-508 compliant). Use this to specify plugin requirements (or the version of virtualenv - determines the default pip, setuptools, and wheel versions the tox environments start with). If these dependencies are not specified tox will create provision_tox_env environment so that they are satisfied and delegate all calls to that.

See https://tox.readthedocs.io/en/latest/config.html#conf-minversion

Define the minimal tox version required to run; if the host’s tox version is less than this the tool will create an environment and provision it with a version of tox that satisfies this under provision_tox_env.

Given a config file like this:

[tox]
minversion = 3.4.0
requires =
    tox-pipenv
    setuptools >= 30.0.0

[testenv]
deps =
    pytest

We currently only print pytest with --print-deps-to=. I'd like to extend it to print:

tox >= 3.4.0
tox-pipenv
setuptools >= 30.0.0
pytest

Before I dive into it, I'd like to know whether this is a good idea or whether I shall add a new option to do this instead.

@FFY00 you currently don't use --print-deps-to= at all, is that right?

@hroncok hroncok added the enhancement New feature or request label Feb 2, 2021
@hroncok hroncok self-assigned this Feb 2, 2021
@FFY00
Copy link
Contributor

FFY00 commented Feb 2, 2021

@FFY00 you currently don't use --print-deps-to= at all, is that right?

I don't, nothing will break 👍

hroncok added a commit to hroncok/tox-current-env that referenced this issue Feb 15, 2021
hroncok added a commit to hroncok/tox-current-env that referenced this issue Feb 15, 2021
@hroncok
Copy link
Member Author

hroncok commented Feb 15, 2021

It will also be quite tricky to actually prevent the provision step if tox determines it is needed. It happens before any plugin code is executed 😕 We might want to document this instead.

hroncok added a commit to hroncok/tox-current-env that referenced this issue Feb 15, 2021
hroncok added a commit to hroncok/tox-current-env that referenced this issue Feb 16, 2021
@hroncok
Copy link
Member Author

hroncok commented Feb 16, 2021

It will also be quite tricky to actually prevent the provision step if tox determines it is needed.

tox-dev/tox#1921

hroncok added a commit to hroncok/tox-current-env that referenced this issue Mar 8, 2021
hroncok added a commit to hroncok/tox-current-env that referenced this issue Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants