Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #5237 fix: typed error for pay_bolt11_invoice #5240

Open
github-actions bot opened this issue May 9, 2024 · 1 comment
Open

Backport PR #5237 fix: typed error for pay_bolt11_invoice #5240

github-actions bot opened this issue May 9, 2024 · 1 comment
Labels
backport

Comments

@github-actions
Copy link

github-actions bot commented May 9, 2024

PR: #5237
Title: fix: typed error for pay_bolt11_invoice

The backport bot failed. Please open a PR to backport these changes.
@elsirion
Copy link
Contributor

elsirion commented May 15, 2024 •
edited

Looks good, should have checked the code instead of assuming the naive typed error approach 😅

I wouldn't backport this: SemVer API break and doesn't seem super critical. Thoughts @maan2003?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elsirion