Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of assume_checked() #5203

Open
tvolk131 opened this issue May 3, 2024 · 0 comments
Open

Remove usage of assume_checked() #5203

tvolk131 opened this issue May 3, 2024 · 0 comments

Comments

@tvolk131
Copy link
Contributor

tvolk131 commented May 3, 2024

Follow-up to #2356

Bitcoin v30 introduced the concept of checked and unchecked addresses. While migrating over from v0.29 to v0.30, I called assume_checked() wherever necessary to make the compiler happy. Now that the migration is complete, we should remove these calls and instead use require_network().

Edit: See this comment in the changelog for bitcoin v0.32.0 which indicates that the work here might not be that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant