You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've migrated almost all of the codebase to bitcoin v0.30, but there are a few places remaining where we're using v0.29 which require some more care to remove:
Ideally we would be able to use impl_encode_decode_bridge!(bitcoin::psbt::PartiallySignedTransaction); like we did prior to the migration to v0.30 but I'm not sure how feasible that is.
bitcoin::network::constants::Magic is encoded/decoded in reverse byte order to v29 (which doesn't have a struct, but instead just uses a u32). See here for details:
bitcoin::hashes::hex::format_hex was removed in v30. For simplicity, we've simply left v29 around to rely on this single function. Let's find a way to retain this behavior without needing v29.
The text was updated successfully, but these errors were encountered:
Follow-up to #2356
We've migrated almost all of the codebase to
bitcoin
v0.30, but there are a few places remaining where we're using v0.29 which require some more care to remove:PartiallySignedTransaction
no longer implementsEncodable
orDecodable
, which is why we're currently converting to/from the v0.29 version when encoding/decoding:fedimint/fedimint-core/src/encoding/btc.rs
Lines 48 to 67 in 93c23e1
Ideally we would be able to use
impl_encode_decode_bridge!(bitcoin::psbt::PartiallySignedTransaction);
like we did prior to the migration to v0.30 but I'm not sure how feasible that is.bitcoin::network::constants::Magic
is encoded/decoded in reverse byte order to v29 (which doesn't have a struct, but instead just uses a u32). See here for details:fedimint/fedimint-core/src/bitcoin_migration.rs
Lines 15 to 39 in 93c23e1
bitcoin::hashes::hex::format_hex
was removed in v30. For simplicity, we've simply left v29 around to rely on this single function. Let's find a way to retain this behavior without needing v29.The text was updated successfully, but these errors were encountered: