Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert most [package] fields to {workspace = true } #5190

Closed
dpc opened this issue May 1, 2024 · 2 comments · Fixed by #5309
Closed

Convert most [package] fields to {workspace = true } #5190

dpc opened this issue May 1, 2024 · 2 comments · Fixed by #5309
Labels
good first issue Good for newcomers

Comments

@dpc
Copy link
Contributor

dpc commented May 1, 2024

This works:

> g diff HEAD
diff --git a/fedimint-bitcoind/Cargo.toml b/fedimint-bitcoind/Cargo.toml
index 573cd58d4b..a12a098bfb 100644
--- a/fedimint-bitcoind/Cargo.toml
+++ b/fedimint-bitcoind/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fedimint-bitcoind"
-version = "0.4.0-alpha"
+version = { workspace = true }
 authors = ["The Fedimint Developers"]
 edition = "2021"
 description = "Bitcoin Core connectivity used by Fedimint"

We should use { workspace = true } for anything that can be done this way, mostly because it expresses the shared nature of these fields well.

@dpc dpc added the good first issue Good for newcomers label May 1, 2024
@Minimega12121
Copy link
Contributor

So do we have to change to { workspace = true } on each cargo or only specific ones ?

This works:

> g diff HEAD
diff --git a/fedimint-bitcoind/Cargo.toml b/fedimint-bitcoind/Cargo.toml
index 573cd58d4b..a12a098bfb 100644
--- a/fedimint-bitcoind/Cargo.toml
+++ b/fedimint-bitcoind/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fedimint-bitcoind"
-version = "0.4.0-alpha"
+version = { workspace = true }
 authors = ["The Fedimint Developers"]
 edition = "2021"
 description = "Bitcoin Core connectivity used by Fedimint"

We should use { workspace = true } for anything that can be done this way, mostly because it expresses the shared nature of these fields well.

So do we have to change version to { workspace = true } on each cargo or only specific ones ?

@dpc
Copy link
Contributor Author

dpc commented May 3, 2024

Everywhere where it makes sense (most if not all Cargo.tomls). `version, authors, edition, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants