Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Who should tell client where to connect for blockchain data #5178

Open
dpc opened this issue Apr 30, 2024 · 1 comment
Open

Who should tell client where to connect for blockchain data #5178

dpc opened this issue Apr 30, 2024 · 1 comment

Comments

@dpc
Copy link
Contributor

dpc commented Apr 30, 2024

For things like deposits and withdrawals and some other stuff the client needs data from L1. Unfortunately most clients can't be expected to have a bitcoind around, and needs to know where to alternatively connect.

The settings here is: backend kind and url. E.g. electrum + https://sometrustedelectrum:53234.

Currently we kind of hack around it in unexpected ways.

Who client/user can trust with providing correct data and privacy?

We probably should obsolete the wallet-module bitcoin rpc config (cfg.default_bitcoin_rpc), as being part of consensus makes it unchangeable and meta seems like the right place for it.

Possible reasonable ways to pass to client bitcoin rpc configuration, in order of preference (IMO):

  • by the user, e.g. in the App UI, passed to the client via env var or direct configuration passed to the client/module
  • defaults(?) by the integrator app, passsed the same way
  • by the Federation, via meta
  • some built-in defaults
@m1sterc001guy
Copy link
Contributor

If I recall correctly, we also have an issue using bitcoind for RPCs on the client: #2955. So the lack of configurability here is also hiding a bug :/

The fix for this will hopefully be unblocked after we upgrade to bitcoin 0.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants