Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUR/ADRs: document_highlights limits to only 3 document hits (Bug) #5817

Closed
6 tasks done
patphongs opened this issue May 8, 2024 · 0 comments · Fixed by #5838
Closed
6 tasks done

MUR/ADRs: document_highlights limits to only 3 document hits (Bug) #5817

patphongs opened this issue May 8, 2024 · 0 comments · Fixed by #5838

Comments

@patphongs
Copy link
Member

patphongs commented May 8, 2024

What we’re after

Currently the document_highlights only returns a max of 3 hits and a max of 5 fragments. We need to return all the hits so that the user can get the full dataset. We need to understand how we can remove the limit for hits from document_highlights.

Elasticsearch highlight documentation: https://www.elastic.co/guide/en/elasticsearch/reference/current/highlighting.html

Example:
When searching query “Reason to believe” and doc_category_id=1 for MUR 4530, it returns 3 matching document hits, but there should be more, at least 7. This is the API call: https://api.open.fec.gov/v1/legal/search?case_no=4530&case_doc_category_id=1&type=murs&hits_returned=20&from_hit=0&q=%22Reason+to+believe%22&api_key=NICAR16

Action item(s)

  • Determine how these limits are being set
  • Remove all document limits, as appropriate
  • Ensure all relevant documents will appear, no documents with a given type will be excluded from the search results

Completion criteria

  • All relevant documents are appearing in search results

References/resources/technical considerations

  • Is there a performance issue when returning all results?
  • Do size parameters in elasticsearch settings help with returning results?
@patphongs patphongs added the Bug label May 8, 2024
@patphongs patphongs added this to the 25.1 milestone May 8, 2024
@patphongs patphongs changed the title document_highlights limits to only 3 (Bug) document_highlights limits to only 3 hits (Bug) May 8, 2024
@patphongs patphongs changed the title document_highlights limits to only 3 hits (Bug) document_highlights limits to only 3 document hits (Bug) May 8, 2024
@JonellaCulmer JonellaCulmer changed the title document_highlights limits to only 3 document hits (Bug) MUR/ADRs: document_highlights limits to only 3 document hits (Bug) May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants