Add MV for national party aggregate data #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkfec
approved these changes
May 15, 2024
fecjjeng
approved these changes
May 20, 2024
There was a problem hiding this comment.
Branch was downloaded to local machine.
-flyway migration executed successfully.
-pytest completed successfully.
-create_sample_db run and confirmed that ofec_totals_national_party_mv is refreshed after ofec_sched_a_national_party_mv and ofec_sched_b_national_party_mv.
Good job. PR approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
The new MV includes aggregate contribution and disbursement of national party accounts. This MV will be used for committee profile page.
Required reviewers
1-2 developers
How to test
pytestflyway migrateto test migrationofec_totals_national_party_mvis refreshed afterofec_sched_a_national_party_mvandofec_sched_b_national_party_mvdropdb cfdm_test
createdb cfdm_test
invoke create_sample_db