[blocked by frontend]Add candidate_id limitation on schedule a aggregate #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fec-jli
changed the title
cnlucas
reviewed
Apr 1, 2024
There was a problem hiding this comment.
This is working well for me, but I think we should consider two things. First, should this get a dep notice to anyone using these endpoints because it would break their code if they are using 10+ candidates? Have you checked API umbrella?
Also, I think that we should make some design/CMS changes to https://www.fec.gov/data/elections/president/2024/ Individual contributions to candidates tables
because it will no longer work for more than 10 candidates, but that's not super clear when using it.
Overall, great job, let me know your thoughts on the above.
fec-jli
changed the title
fec-jli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
This PR will add filter by "candidate_id" limitation (max =10) on three endpoints:
ScheduleABySizeCandidateView
ScheduleAByStateCandidateView
ScheduleAByStateCandidateTotalsView
Required reviewers
1-2 devs
Impacted areas of the application
ScheduleABySizeCandidateView
ScheduleAByStateCandidateView
ScheduleAByStateCandidateTotalsView
How to test
1)/schedules/schedule_a/by_size/by_candidate/:
pass 10 candidate_ids:
http://127.0.0.1:5000/v1/schedules/schedule_a/by_size/by_candidate/?sort=size&candidate_id=P80001571&candidate_id=S2TX00106&candidate_id=H6IL09061&candidate_id=H8IA01094&candidate_id=H8MO03164&candidate_id=P80003338&candidate_id=H6MT01095&candidate_id=H4CA12055&candidate_id=S6CT00042&candidate_id=S2ND00099&cycle=2020&election_full=true&per_page=200
pass 11 candidate_ids:
http://127.0.0.1:5000/v1/schedules/schedule_a/by_size/by_candidate/?sort=size&candidate_id=P80001571&candidate_id=S2TX00106&candidate_id=H6IL09061&candidate_id=H8IA01094&candidate_id=H8MO03164&candidate_id=P80003338&candidate_id=H6MT01095&candidate_id=H4CA12055&candidate_id=S6CT00042&candidate_id=S2ND00099&candidate_id=P80003353&cycle=2020&election_full=true&per_page=200
2)/schedules/schedule_a/by_state/by_candidate/
pass 10 candidate_ids:
http://127.0.0.1:5000/v1/schedules/schedule_a/by_state/by_candidate/?sort=state&candidate_id=P80001571&candidate_id=S2TX00106&candidate_id=H6IL09061&candidate_id=H8IA01094&candidate_id=H8MO03164&candidate_id=P80003338&candidate_id=H6MT01095&candidate_id=H4CA12055&candidate_id=S6CT00042&candidate_id=S2ND00099&cycle=2020&election_full=true&per_page=200
pass 11 candidate_ids:
http://127.0.0.1:5000/v1/schedules/schedule_a/by_state/by_candidate/?sort=state&candidate_id=P80001571&candidate_id=S2TX00106&candidate_id=H6IL09061&candidate_id=H8IA01094&candidate_id=H8MO03164&candidate_id=P80003338&candidate_id=H6MT01095&candidate_id=H4CA12055&candidate_id=S6CT00042&candidate_id=S2ND00099&candidate_id=P80003353&cycle=2020&election_full=true&per_page=200
3)/schedules/schedule_a/by_state/by_candidate/totals
pass 10 candidate_ids:
http://127.0.0.1:5000/v1/schedules/schedule_a/by_state/by_candidate/totals/?sort=total&candidate_id=P80001571&candidate_id=S2TX00106&candidate_id=H6IL09061&candidate_id=H8IA01094&candidate_id=H8MO03164&candidate_id=P80003338&candidate_id=H6MT01095&candidate_id=H4CA12055&candidate_id=S6CT00042&candidate_id=S2ND00099&cycle=2020&election_full=true&per_page=200
pass 11 candidate_ids:
http://127.0.0.1:5000/v1/schedules/schedule_a/by_state/by_candidate/totals/?sort=total&candidate_id=P80001571&candidate_id=S2TX00106&candidate_id=H6IL09061&candidate_id=H8IA01094&candidate_id=H8MO03164&candidate_id=P80003338&candidate_id=H6MT01095&candidate_id=H4CA12055&candidate_id=S6CT00042&candidate_id=S2ND00099&candidate_id=P80003353&cycle=2020&election_full=true&per_page=200