Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limitation for candidate_id to ScheduleABySizeCandidateView, ScheduleAByStateCandidateView and ScheduleABySizeCandidateTotalsView #5753

Open
1 of 7 tasks
fec-jli opened this issue Mar 11, 2024 · 0 comments · May be fixed by #5779
Open
1 of 7 tasks

Add limitation for candidate_id to ScheduleABySizeCandidateView, ScheduleAByStateCandidateView and ScheduleABySizeCandidateTotalsView #5753

fec-jli opened this issue Mar 11, 2024 · 0 comments · May be fixed by #5779
Assignees
@fec-jli
Labels
Technical debt Work: Back-end
Milestone
24.5

Comments

@fec-jli
Copy link
Contributor

fec-jli commented Mar 11, 2024 •
edited by patphongs

What we’re after

This PR will add candidate_id limitation number search on these three endpoints:
ScheduleABySizeCandidateView
ScheduleAByStateCandidateView
ScheduleAByStateCandidateTotalsView

Related ticket(s)

Remove per_page cap on ScheduleABySizeCandidateView, ScheduleAByStateCandidateView, and ScheduleAByStateCandidateTotalsView

Tech steps

Completion criteria

  • Only allow user to search max 10 of candidate_id
  • Add autotest
  • Notice api users
@fec-jli fec-jli added this to the 24.4 milestone Mar 11, 2024
@cnlucas cnlucas modified the milestones: 24.4, 24.5 Mar 12, 2024
@fec-jli fec-jli changed the title Add limitation for candidate_id to No Cap endpoints Add limitation for candidate_id to ScheduleABySizeCandidateView, ScheduleAByStateCandidateView and ScheduleABySizeCandidateTotalsView Mar 31, 2024
@fec-jli fec-jli linked a pull request Mar 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fec-jli fec-jli

Labels
Technical debt Work: Back-end
Projects
Website project
Status: 👀 Ready
Milestone
24.5
Development

Successfully merging a pull request may close this issue.

[blocked by frontend]Add candidate_id limitation on schedule a aggregate fecgov/openFEC
4 participants
@patphongs @fec-jli @cnlucas @tmpayton