Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest apispec and flask-apispec versions #3356

Closed
lbeaufort opened this issue Sep 4, 2018 · 2 comments · Fixed by #3362
Closed

Upgrade to latest apispec and flask-apispec versions #3356

lbeaufort opened this issue Sep 4, 2018 · 2 comments · Fixed by #3362
Assignees
@lbeaufort
Labels
Technical debt
Milestone
Sprint 7.2

Comments

@lbeaufort
Copy link
Member

So that we are ready to upgrade apispec and flask-apispec when they (hopefully) fix a PyYAML vulnerability, we should update to the highest version of both packages.
@lbeaufort lbeaufort mentioned this issue Sep 4, 2018
Closed
3 tasks
@lbeaufort lbeaufort added this to the Sprint 7.1 milestone Sep 4, 2018
@lbeaufort lbeaufort self-assigned this Sep 4, 2018
lbeaufort added a commit that referenced this issue Sep 4, 2018
@lbeaufort
Update apispec package to 0.39.0
ac7fae2 
Addresses #3356
@lbeaufort lbeaufort mentioned this issue Sep 4, 2018
Merged
lbeaufort added a commit that referenced this issue Sep 4, 2018
@lbeaufort
Update apispec package to 0.39.0
39090a6 
Addresses #3356
lbeaufort added a commit that referenced this issue Sep 4, 2018
@lbeaufort
Update flask-apispec package to 0.7.0
b60ce87 
Addresses #3356
lbeaufort added a commit that referenced this issue Sep 4, 2018
@lbeaufort
Update apispec package to 0.39.0
510479d 
Addresses #3356

New `prance` package is used for `validate_spec`
lbeaufort added a commit that referenced this issue Sep 4, 2018
@lbeaufort
Update flask-apispec package to 0.7.0
3ff5b24 
Addresses #3356
lbeaufort added a commit that referenced this issue Sep 5, 2018
@lbeaufort
Update apispec package to 0.39.0
e851aa5 
Addresses #3356

- New `prance` package is used for `validate_spec`
- Additional imports needed for swagger tests
lbeaufort added a commit that referenced this issue Sep 5, 2018
@lbeaufort
Update flask-apispec package to 0.7.0
df19f8d 
Addresses #3356
@lbeaufort
Copy link
Member Author

lbeaufort commented Sep 6, 2018 •
edited

Update: There is one issue preventing tests from passing with the upgrade, that is looking like it might be an issue with the apispec package itself. We should probably put in an issue to their repo. In the meantime, I've forked it and made the change so we can test the implementation to make sure there aren't any other issues.

We can pull in the forked repo in requirements.txt like this: git+https://github.com/fecgov/apispec.git

https://github.com/fecgov/apispec/pull/1

cc: @vrajmohan

@lbeaufort
Copy link
Member Author

Plan forward: fork latest release of apispec, make this change: https://github.com/fecgov/apispec/pull/1 and pull in the forked repo in requirements.txt like this: git+https://github.com/fecgov/apispec.git

@lbeaufort lbeaufort modified the milestones: Sprint 7.1, Sprint 7.2 Sep 17, 2018
lbeaufort added a commit that referenced this issue Sep 18, 2018
@lbeaufort
Update apispec package to 0.39.0
6c9956d 
Addresses #3356

- New `prance` package is used for `validate_spec`
- Additional imports needed for swagger tests
lbeaufort added a commit that referenced this issue Sep 18, 2018
@lbeaufort
Update flask-apispec package to 0.7.0
e9d0728 
Addresses #3356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbeaufort lbeaufort

Labels
Technical debt
Projects
None yet
Milestone
Sprint 7.2
Development

Successfully merging a pull request may close this issue.

Update apispec package to use fecgov's forked repo fecgov/openFEC
1 participant
@lbeaufort