From e393908328b6b8ffbde1a16c8dd42b6995cb4f7a Mon Sep 17 00:00:00 2001 From: Ray Foss Date: Tue, 19 Oct 2021 06:14:32 -0500 Subject: [PATCH 1/4] Support ambient types in dev environment by default ts-node and by dependency, ts-node-dev, will ignore ambient types without the files flag. Meanwhile tsc, which we use to build... will load ambient types. This is unexpected for most people. This PR fixes that and has few if any ramifications. --- packages/cli/_templates/app/base/ts/tsconfig.json.t | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/cli/_templates/app/base/ts/tsconfig.json.t b/packages/cli/_templates/app/base/ts/tsconfig.json.t index 4ab2ebe349..df7d7d74c3 100644 --- a/packages/cli/_templates/app/base/ts/tsconfig.json.t +++ b/packages/cli/_templates/app/base/ts/tsconfig.json.t @@ -2,8 +2,11 @@ to: "tsconfig.json" --- { + "ts-node": { + "files": true + }, "compilerOptions": { - "target": "es2018", + "target": "es2020", "module": "commonjs", "outDir": "./lib", "rootDir": "./<%= h.lib %>", @@ -13,4 +16,4 @@ to: "tsconfig.json" "exclude": [ "test" ] -} \ No newline at end of file +} From 8e7041b38a940072f45a194577db5f0b1bacb353 Mon Sep 17 00:00:00 2001 From: Ray Foss Date: Tue, 19 Oct 2021 06:33:18 -0500 Subject: [PATCH 2/4] switch to nodemon for dev mode change detection --- packages/cli/_templates/app/base/ts/package.json.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/_templates/app/base/ts/package.json.t b/packages/cli/_templates/app/base/ts/package.json.t index daef59283e..33e898cd41 100644 --- a/packages/cli/_templates/app/base/ts/package.json.t +++ b/packages/cli/_templates/app/base/ts/package.json.t @@ -9,7 +9,7 @@ const pkg = { ...h.pkg, scripts: { ...h.pkg.scripts, - dev: 'ts-node-dev --no-notify ${h.lib}/', + dev: 'nodemon -x ts-node ${h.lib}/', compile: 'shx rm -rf lib/ && tsc', start: 'npm run compile && node lib/', test: 'mocha test/ --require ts-node/register --recursive --extension .ts --exit' From bd679495572170cd16fefd3fbede6b259e646435 Mon Sep 17 00:00:00 2001 From: Ray Foss Date: Tue, 19 Oct 2021 06:34:18 -0500 Subject: [PATCH 3/4] nodemon reads the extension of the first argument Otherwise, ts would be ignored --- packages/cli/_templates/app/base/ts/package.json.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/_templates/app/base/ts/package.json.t b/packages/cli/_templates/app/base/ts/package.json.t index 33e898cd41..4a6cea0492 100644 --- a/packages/cli/_templates/app/base/ts/package.json.t +++ b/packages/cli/_templates/app/base/ts/package.json.t @@ -9,7 +9,7 @@ const pkg = { ...h.pkg, scripts: { ...h.pkg.scripts, - dev: 'nodemon -x ts-node ${h.lib}/', + dev: 'nodemon -x ts-node ${h.lib}/index.ts', compile: 'shx rm -rf lib/ && tsc', start: 'npm run compile && node lib/', test: 'mocha test/ --require ts-node/register --recursive --extension .ts --exit' From d275f12e28cb7c31694839f4cd48272f0fcbad4d Mon Sep 17 00:00:00 2001 From: Ray Foss Date: Tue, 19 Oct 2021 06:37:20 -0500 Subject: [PATCH 4/4] updating devDependecies for ts-node --- packages/cli/_templates/app/base/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cli/_templates/app/base/index.js b/packages/cli/_templates/app/base/index.js index 747f6f47f2..f22362a34a 100644 --- a/packages/cli/_templates/app/base/index.js +++ b/packages/cli/_templates/app/base/index.js @@ -45,7 +45,8 @@ module.exports = { '@types/mocha', feathers.framework === 'koa' ? '@types/koa-static' : '@types/compression', '@types/node', - 'ts-node-dev', + 'nodemon', + 'ts-node', 'typescript', 'shx' );