This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
[0.16] Regression in Constraint::Min for tables #525
Labels
Comments
|
I noticed that the table example only shows 2 rows in 0.16 instead of 3 rows which are provided in the code and
|
fdehau
added a commit
that referenced
this issue
Nov 21, 2021
Third column in table example was using the `Max` constraint. But since version 0.16, the layout system does not add a hidden constraint on the last column which would ensure that it fills the remaining available space (a change that was already mentioned in #525). In addition, `tui` does not support sizing based on content because of its immediate mode nature. Therefore, `Max` is now resolved to `0`. Replacing with `Min` fixes the issue. A new way of specifying constraints is being worked on at #519 which should for more deterministic and advanced layout.
fdehau
added a commit
that referenced
this issue
Nov 21, 2021
Third column in table example was using the `Max` constraint. But since version 0.16, the layout system does not add a hidden constraint on the last column which would ensure that it fills the remaining available space (a change that was already mentioned in #525). In addition, `tui` does not support sizing based on content because of its immediate mode nature. Therefore, `Max` is now resolved to `0`. Replacing with `Min` fixes the issue. A new way of specifying constraints is being worked on at #519 which should for more deterministic and advanced layout.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Before 0.16 our table layout worked with all columns being precisely sized and then using
Constraint::Min(0)to use all the rest of available space to fill. This worked and 0.16 did not mentioned anything about this being changes but it does not work anymore.To Reproduce
Switching to
Constraint::Percentage(100)luckily workaround the issue.See: https://github.com/extrawurst/gitui/pull/845/files
Expected behavior
The previous behaviour.
Screenshots
Before we upgraded to
0.16:After we upgraded to
0.16:Environment
Additional context
I assume this regression was introduced in: #514
The text was updated successfully, but these errors were encountered: