This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
fix(widgets/table): improve computation of table column widths #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sum of the columns widths returned by
Table::get_column_widths
can sometimes be greater than the available width. This is happening because we are not feeding enough constraints to thecassowary
solver. At the same time we already have an abstraction overcassowary
which is used everywhere else:Layout
. Therefore, I've replaced the manual column widths computation by a call toLayout
.Fixes #470
Testing guidelines
A regression test provided in #508 was used to test the solution.
Checklist