Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nth-check dependency v1.0.2 is vulnerable #743

Closed
skubot opened this issue Apr 11, 2022 · 6 comments
Closed

nth-check dependency v1.0.2 is vulnerable #743

skubot opened this issue Apr 11, 2022 · 6 comments

Comments

@skubot
Copy link

skubot commented Apr 11, 2022

Hi there, I got an alert from Snyk;
https://snyk.io/vuln/npm:css-select@2.1.0

css-select uses an old version of nth-check... needs to be upgraded to v2.0.1 or later. Thanks.

@fb55
Copy link
Owner

fb55 commented Apr 11, 2022

That site doesn't have an vulnerabilities listed:

No known vulnerabilities have been found for this package in Snyk's vulnerability database.

@fb55
Copy link
Owner

fb55 commented Apr 11, 2022

The range for nth-check allows for the current version. An npm audit --fix will resolve any issue you have.

@fb55 fb55 closed this as completed Apr 11, 2022
@skubot
Copy link
Author

skubot commented Apr 11, 2022

Oh my god you're right sorry... the issue is that react-scripts@5.0.0 is using some older libraries downstream
ie: svgo@1.3.2 uses old css-select@2.1.0 which used to use nth-check@1.0.2

@chrisfinazzo
Copy link

chrisfinazzo commented Apr 13, 2022

For projects using Create React App, the fix is a breaking change and as configured it will install react-scripts@0.9.5 - which is super old.

Not exactly what I hoped to see.

@fb55
Copy link
Owner

fb55 commented Apr 13, 2022

@gaearon has written a great explanation of how to deal with and think about this: facebook/create-react-app#11174

@chrisfinazzo
Copy link

chrisfinazzo commented Apr 13, 2022

@gaearon has written a great explanation of how to deal with and think about this: facebook/create-react-app#11174

Good to know, thanks.

For the record, there is also a Prototype Pollution issue in async (another one of the transitive dependencies in CRA) which suggests the same fix. The PR for that is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants