forked from rubocop/rubocop
/
case_equality.rb
72 lines (65 loc) · 1.75 KB
/
case_equality.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# This cop checks for uses of the case equality operator(===).
#
# @example
# # bad
# Array === something
# (1..100) === 7
# /something/ === some_string
#
# # good
# something.is_a?(Array)
# (1..100).include?(7)
# some_string =~ /something/
#
# @example AllowOnConstant
# # Style/CaseEquality:
# # AllowOnConstant: true
#
# # bad
# (1..100) === 7
# /something/ === some_string
#
# # good
# Array === something
# (1..100).include?(7)
# some_string =~ /something/
#
class CaseEquality < Base
extend AutoCorrector
MSG = 'Avoid the use of the case equality operator `===`.'
def_node_matcher :case_equality?, '(send $#const? :=== $_)'
def on_send(node)
case_equality?(node) do |lhs, rhs|
add_offense(node.loc.selector) do |corrector|
replacement = replacement(lhs, rhs)
corrector.replace(node, replacement) if replacement
end
end
end
private
def const?(node)
if cop_config.fetch('AllowOnConstant', false)
!node&.const_type?
else
true
end
end
def replacement(lhs, rhs)
case lhs.type
when :regexp
"#{rhs.source} =~ #{lhs.source}"
when :begin
child = lhs.children.first
"#{lhs.source}.include?(#{rhs.source})" if child&.range_type?
when :const
"#{rhs.source}.is_a?(#{lhs.source})"
end
end
end
end
end
end