🎁 Add FORCE_COLOR support #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @fatih Can I ask you for a review? 🙏 |
|
@fatih +1, we have a project that would love to see this capability merged (and released 😁). |
pellared
suggested changes
Nov 14, 2022
| if ev, set := os.LookupEnv("FORCE_COLOR"); set { | ||
| ev = strings.ToLower(ev) | ||
| if mode, err := strconv.Atoi(ev); err == nil { | ||
| return colorMode(mode) |
There was a problem hiding this comment.
undocumented functionality (nor in README.md nor in doc comments)
|
Sorry for the late response. But this feature adds complexity that I'm not willing to maintain in the long run. Forcing color is something that library importers can easily add themselves. I'll evaluate it in the future again if this becomes a standard in the industry (and by standard, I mean it's widely used). @cardil thanks for you work though, and I hope you understand why I don't want to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155