From fca6a8bb05aab41542999391992a82f00e566d29 Mon Sep 17 00:00:00 2001 From: Max Ott Date: Mon, 19 Apr 2021 11:55:05 +0200 Subject: [PATCH 1/2] Fix case sensitive email issue Apple treats emails case sensitive. Sample: `Spaceship::Members.all` => `"emil.dvorjak@acme.com", "Stacy.Hammilton@acme.com", "samual.Ethan@acme.com"` If you search for `Spaceship::Members.find("stacy.hammilton@acme.com")`, the call will fail, because there is no match. This PR tries to fix the issue. --- spaceship/lib/spaceship/tunes/members.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spaceship/lib/spaceship/tunes/members.rb b/spaceship/lib/spaceship/tunes/members.rb index d112b124cc7..e0ea0f08c29 100644 --- a/spaceship/lib/spaceship/tunes/members.rb +++ b/spaceship/lib/spaceship/tunes/members.rb @@ -15,7 +15,7 @@ def all def find(email) all.each do |member| - if member.email_address == email + if member.email_address.downcase == email return member end end From c86d005783db03fef3bba6c36e40d874ba141d8a Mon Sep 17 00:00:00 2001 From: Max Ott Date: Mon, 19 Apr 2021 12:20:28 +0200 Subject: [PATCH 2/2] Update spaceship/lib/spaceship/tunes/members.rb Smarter comparison! Co-authored-by: Josh Holtz --- spaceship/lib/spaceship/tunes/members.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spaceship/lib/spaceship/tunes/members.rb b/spaceship/lib/spaceship/tunes/members.rb index e0ea0f08c29..1aa2f94636d 100644 --- a/spaceship/lib/spaceship/tunes/members.rb +++ b/spaceship/lib/spaceship/tunes/members.rb @@ -15,7 +15,7 @@ def all def find(email) all.each do |member| - if member.email_address.downcase == email + if member.email_address.casecmp?(email) return member end end