From 001dc20a67b2a722be7992e1b073eeb782d07d10 Mon Sep 17 00:00:00 2001 From: xpy Date: Fri, 10 May 2019 14:12:22 +0200 Subject: [PATCH 1/2] add a check in setup_screenshots to also check if there is an app_preview alredy uploaded --- spaceship/lib/spaceship/tunes/app_version.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spaceship/lib/spaceship/tunes/app_version.rb b/spaceship/lib/spaceship/tunes/app_version.rb index cf8cb29418c..d2fa5b1c192 100644 --- a/spaceship/lib/spaceship/tunes/app_version.rb +++ b/spaceship/lib/spaceship/tunes/app_version.rb @@ -713,9 +713,14 @@ def setup_screenshots language_details = raw_data_details.each do |current_language| language_details = (current_language["displayFamilies"] || {})["value"] (language_details || []).each do |device_language_details| + # Do not enable scaling if a screenshot already exists next if device_language_details["screenshots"].nil? next if device_language_details["screenshots"]["value"].count > 0 + # Do not enable scaling if a trailer already exists + next if device_language_details["trailers"].nil? + next if device_language_details["trailers"]["value"].count > 0 + # The current row includes screenshots for all device types # so we need to enable scaling for both iOS and watchOS apps device_language_details["scaled"]["value"] = true if device_language_details["scaled"] From 108844bcfee31d1c60358c1d33cc3335348e4c8b Mon Sep 17 00:00:00 2001 From: xpy Date: Mon, 13 May 2019 08:32:56 +0200 Subject: [PATCH 2/2] improve commenting --- spaceship/lib/spaceship/tunes/app_version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spaceship/lib/spaceship/tunes/app_version.rb b/spaceship/lib/spaceship/tunes/app_version.rb index d2fa5b1c192..5743ef99c7c 100644 --- a/spaceship/lib/spaceship/tunes/app_version.rb +++ b/spaceship/lib/spaceship/tunes/app_version.rb @@ -708,7 +708,7 @@ def container_data_for_language_and_device(data_field, language, device) end def setup_screenshots - # Enable Scaling for all screen sizes that don't have at least one screenshot + # Enable Scaling for all screen sizes that don't have at least one screenshot or at least one trailer (app_preview) # We automatically disable scaling once we upload at least one screenshot language_details = raw_data_details.each do |current_language| language_details = (current_language["displayFamilies"] || {})["value"]