Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all specs are enabled since the move to monogem #7559

Merged
merged 2 commits into from
Dec 17, 2016
Merged

Not all specs are enabled since the move to monogem #7559

merged 2 commits into from
Dec 17, 2016

Conversation

lacostej
Copy link
Collaborator

This reveals lots of failure. Not yet looked into.

@KrauseFx
Copy link
Member

Oh wow, nice catch. This needs also to be updated in circle.yml, so that the CI build fails as well. I see there are 40 failures with that change.

@KrauseFx
Copy link
Member

Oh and this would only run 998 tests, that's not all

@KrauseFx
Copy link
Member

rspec --pattern ./**/*_spec.rb
this seems to be the pattern that would include all the tests 👍

@KrauseFx
Copy link
Member

Please update the pattern at both location to the one I posted, and merge lacostej#4 into your branch 👍 This will make all 3394 tests green 💚

@KrauseFx KrauseFx merged commit b1800cf into fastlane:master Dec 17, 2016
@KrauseFx
Copy link
Member

Thanks for updating the PR 👍

@fastlane fastlane locked and limited conversation to collaborators Mar 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KrauseFx KrauseFx KrauseFx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lacostej @KrauseFx