Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--fail-on-errors" support to Danger action #7487

Merged
merged 2 commits into from
Dec 16, 2016

Conversation

nikolaykasyanov
Copy link
Contributor

Adds optional boolean fail_on_errors parameter to Danger action.

FastlaneCore::ConfigItem.new(key: :fail_on_errors,
env_name: "FL_DANGER_FAIL_ON_ERRORS",
description: "Should always fail the build process, defaults
to false",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to be one line only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 🎉

@KrauseFx KrauseFx merged commit acdd458 into fastlane:master Dec 16, 2016
@KrauseFx
Copy link
Member

Nice, thank you for your contribution @nikolaykasyanov 👍

@KrauseFx KrauseFx mentioned this pull request Dec 17, 2016
@fastlane fastlane locked and limited conversation to collaborators Mar 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants