Update README.md #7385
Merged
Update README.md #7385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where do you have that information from? Maybe we could link to to the documentation instead? |
|
Thanks for the pull request, this looks great otherwise 👍 |
|
It was after I looked at the already linked Java document I realised it could be specified on the command-line. from: http://docs.oracle.com/javase/8/docs/technotes/guides/net/proxies.html |
KrauseFx
reviewed
Dec 9, 2016
| @@ -250,6 +250,11 @@ TOOLS_PATH=$( xcode-select -p ) | |||
| REL_PATH='../Applications/Application Loader.app/Contents/itms/java/lib/net.properties' | |||
| echo "$TOOLS_PATH/$REL_PATH" | |||
| ``` | |||
| As an alternative to editing the properties files, proxy configuration can be specified on the command line directly: | |||
There was a problem hiding this comment.
Is the order correct? Should this be below the proxy configuration link below?
There was a problem hiding this comment.
Yeah, good call. Updated.
KrauseFx
approved these changes
Dec 12, 2016
|
Sorry CI is failing, could you rebase from master or submit a new PR with these changes? Thanks |
Added some additional examples using proxies and iTunes Transporter
Switch ordering of text to _after_ the java doc links
|
rebased.. |
|
Beautiful, thanks 👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some additional examples using proxies and iTunes Transporter.
This hopefully will save folks time as it took me a while how to configure a proxy on our Jenkins environment that is behind a firewall, without having access to update slave installs of the uploader application.