Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update path to iTMSTransporter for Fastlane.swift #20795

Merged
merged 1 commit into from Nov 12, 2022

Conversation

rafauke
Copy link
Contributor

@rafauke rafauke commented Oct 27, 2022

The path provided in the document no longer works, iTMSTransporter has to be run from a different directory.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

Testing Steps

The path provided in the document no longer works, `iTMSTransporter` has to be run from a different directory.
@google-cla
Copy link

google-cla bot commented Oct 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@freddi-kit
Copy link
Contributor

freddi-kit commented Nov 10, 2022

This is not ideal fix IMO. From Xcode 14, there is no iTMSTransporter and officialy removed. So it would be better to consider the path which is expected to use Transporter.app

#20371 (comment)

@rafauke
Copy link
Contributor Author

rafauke commented Nov 10, 2022

This is not ideal fix IMO. From Xcode 14, there is no iTMSTransporter and officialy removed. So it would be better to consider the path which is expected to use Transporter.app

#20371 (comment)

Correct. This is just to help people that are looking for the transporter right now. Maybe both messages should be present for historical/backwards compatibility reasons.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you for this 😊

@joshdholtz joshdholtz changed the title Update path to iTMSTransporter [docs] update path to iTMSTransporter for Fastlane.swift Nov 12, 2022
@joshdholtz joshdholtz merged commit 669a4a5 into fastlane:master Nov 12, 2022
@fastlane-bot
Copy link

Hey @rafauke 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.211.0 🚀

@rafauke rafauke deleted the patch-2 branch January 19, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants