New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] update path to iTMSTransporter for Fastlane.swift #20795
Conversation
The path provided in the document no longer works, `iTMSTransporter` has to be run from a different directory.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This is not ideal fix IMO. From Xcode 14, there is no iTMSTransporter and officialy removed. So it would be better to consider the path which is expected to use Transporter.app |
Correct. This is just to help people that are looking for the transporter right now. Maybe both messages should be present for historical/backwards compatibility reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you for this 😊
Hey @rafauke 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.211.0 🚀 |
The path provided in the document no longer works,
iTMSTransporter
has to be run from a different directory.Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Testing Steps