New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pilot][deliver] Fix how to encode base64 p8 key on deliver and pilot #20669
Conversation
@crazymanish @AliSoftware Could you take a look it with #20662? It is bug affect to pilot action 😢 |
@@ -22,7 +22,6 @@ class Token | |||
attr_reader :expiration | |||
|
|||
attr_reader :key_raw | |||
attr_reader :is_key_content_base64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is added by https://github.com/fastlane/fastlane/pull/20631/files#diff-ba9086d4da8fe68c8c84efaffba0f85f39d64b5a1c08b0a6db13360783e10007R25 but now no longer necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it (I don't have an API Key around on my personal Mac from where I'm reviewing this) but code logic looks good to me 👍
Co-authored-by: Olivier Halligon <olivier@halligon.net>
@AliSoftware Thanks, I fixed! |
I've been dealing with the exact same issue #20663 since the release of Xcode 14 on Azure Devops. I'm glad you've found the root cause and fixed it. Can't wait to merge & release it already! Thanks!🥇 |
Hey @freddi-kit, what can we do to move this forward? |
Please wait fastlane member's action 🙇 I cannot do anything more |
@AliSoftware, sorry to be a bother, but do you know if anyone on the fastlane team is planning on taking a look at this PR? This fixes what seems to be a blocking issue for me using Xcode 14 as well. It would be greatly appreciated ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Will get a new version pushed out right away 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.210.1 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #20663
Currently transporter class tries to decode Base64 not only encoded key but also not encoded key (e.g. loaded token from
Spaceship::ConnectAPI.token
). It causes #20663Description
Testing Steps
Test with api_key like below