Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pilot][deliver] fix private method clone' called for #<Hash> on uploading app #20662

Merged
merged 1 commit into from Nov 12, 2022

Conversation

freddi-kit
Copy link
Contributor

@freddi-kit freddi-kit commented Sep 15, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fixes: #20631 (comment) by #20631 (comment)

Description

Use dup instead of clone when copying api_key

Testing Steps

run

I tested by pure project with below fastfile

default_platform(:ios)

platform :ios do
  desc "Description of what the lane does"
  lane :custom_lane do
    xcode_select("/Applications/Xcode_14.app")
    # add actions here: https://docs.fastlane.tools/actions
    build_app(
      scheme: "EmptyTestApp",
      configuration: "Release",
      export_options: {
        provisioningProfiles: {
          "com.freddi.testapp.EmptyTestApp" => "release",
        },
      },
      silent: true,
      clean: true
    )
    deliver(
      submit_for_review: false,
      automatic_release: false,
      force: true, # Skip HTMl report verification
      skip_metadata: true,
      skip_screenshots: true,
      skip_binary_upload: false
    )
    # pilot(
    #  username: "test@test.com"
    # )
  end
end

Copy link
Member

@crazymanish crazymanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@azilbershtein
Copy link

Thanks for this PR, when are you planning to merge it?

@freddi-kit
Copy link
Contributor Author

could someone take a look it?

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@azilbershtein
Copy link

@freddi-kit Merge? :)

@freddi-kit
Copy link
Contributor Author

I'm not fastlane member so I wanna ask @crazymanish or @joshdholtz to merge it

@crazymanish
Copy link
Member

i can merge this PR, but can't release it. only Josh has permission to make a Fastlane release!
Till we have a new Fastlane release, users can point Fastlane to this PR git-branch...please find the steps.

Point Fastlane to this PR git-branch

  • Update Gemfile to 👇 and run bundle install, bundle update fastlane, or bundle update
gem "fastlane", :git => "https://github.com/freddi-kit/fastlane.git", :branch => "fix-altool-key-clone"

i will ping Josh on slack to make a new release soon.

@freddi-kit
Copy link
Contributor Author

@joshdholtz it is also necessary for some engineer to solve pilot issue, please take a look when you have time 🙇

@joshdholtz
Copy link
Member

Thank you for ping! Will take a look 😊

And sorry for slow response as of lately! Me and wife are expecting a new baby in a few days so definitely a little bit off my game 😛

Feel free to ping me (multiple times if needed) if anything urgent comes up! I don't mind because I want to solve/release the urgent things 💪

@freddi-kit
Copy link
Contributor Author

And sorry for slow response as of lately! Me and wife are expecting a new baby in a few days so definitely a little bit off my game 😛

Oh, congrats! We have a workaround to use my forked branch so it would not be so urgent. Please take your time.

@freddi-kit
Copy link
Contributor Author

"Family First" 💪 💪 💪 💪

@azilbershtein
Copy link

@joshdholtz Hi, any chance you can take a look?

@azilbershtein
Copy link

Any updates about that?

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, sorry! It took me a long longer to get back into things and catch up from my family leave than I thought 🤦‍♂️

This looks great and will ship this soon!

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.211.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants