New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pilot][deliver] fix private method clone' called for #<Hash> on uploading app #20662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
Thanks for this PR, when are you planning to merge it? |
could someone take a look it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@freddi-kit Merge? :) |
I'm not fastlane member so I wanna ask @crazymanish or @joshdholtz to merge it |
i can merge this PR, but can't release it. only Josh has permission to make a Fastlane release! Point Fastlane to this PR git-branch
gem "fastlane", :git => "https://github.com/freddi-kit/fastlane.git", :branch => "fix-altool-key-clone" i will ping Josh on slack to make a new release soon. |
@joshdholtz it is also necessary for some engineer to solve pilot issue, please take a look when you have time 🙇 |
Thank you for ping! Will take a look 😊 And sorry for slow response as of lately! Me and wife are expecting a new baby in a few days so definitely a little bit off my game 😛 Feel free to ping me (multiple times if needed) if anything urgent comes up! I don't mind because I want to solve/release the urgent things 💪 |
Oh, congrats! We have a workaround to use my forked branch so it would not be so urgent. Please take your time. |
"Family First" 💪 💪 💪 💪 |
@joshdholtz Hi, any chance you can take a look? |
Any updates about that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, sorry! It took me a long longer to get back into things and catch up from my family leave than I thought 🤦♂️
This looks great and will ship this soon!
Congratulations! 🎉 This was released as part of fastlane 2.211.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Fixes: #20631 (comment) by #20631 (comment)
Description
Use dup instead of clone when copying api_key
Testing Steps
run
I tested by pure project with below fastfile