Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][update_code_signing_settings] add sdk key to update_code_signing_settings #20655

Merged

Conversation

gabimoncha
Copy link
Contributor

@gabimoncha gabimoncha commented Sep 14, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Following iPhone 16 and Xcode 14, when switching any iOS provisioning profile the sdk is added in project.pbxproj, e.g. "DEVELOPMENT_TEAM[sdk=iphoneos*]", because now changes are done per SDKs.

Screenshot 2022-09-14 at 12 49 30

Description

I've left the default without any SDK, but allow for an sdk key with the following values iphoneos*, macosx*, iphonesimulator*

Testing Steps

@google-cla
Copy link

google-cla bot commented Sep 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gabimoncha gabimoncha changed the title feat: Add sdk param to update_code_signing_settings feat: Add sdk key to update_code_signing_settings Sep 14, 2022
@gabimoncha
Copy link
Contributor Author

@joshdholtz @AliSoftware - can we merge this too?

@joshdholtz joshdholtz changed the title feat: Add sdk key to update_code_signing_settings [action][update_code_signing_settings] add sdk key to update_code_signing_settings Nov 12, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you 😊

And sorry for taking so long! I was on family leave and it took me a lot longer to get back to things than I thought 🤦‍♂️

@joshdholtz joshdholtz merged commit 96e71d5 into fastlane:master Nov 12, 2022
@gabimoncha gabimoncha deleted the gabimoncha/feat/update_code_signing branch November 13, 2022 09:26
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.211.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants